[11.x] Fixes config:publish with dontMergeFrameworkConfiguration() set to true
#51751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
set to `true` fixes #51736 Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
crynobone
changed the title
config:publish with dontMergeFrameworkConfiguration()config:publish with dontMergeFrameworkConfiguration() set to true
crynobone
commented
Jun 10, 2024
| @@ -57,7 +58,7 @@ protected function mergeAdditionalProviders(Application $app) | |||
| $app->make('config')->set( | |||
| 'app.providers', | |||
| array_merge( | |||
| $app->make('config')->get('app.providers'), | |||
| $app->make('config')->get('app.providers') ?? ServiceProvider::defaultProviders()->toArray(), | |||
There was a problem hiding this comment.
Fixed scenario where app.php configuration file is not available. Verified with tests below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #51736