[11.x] Add unprocessableContent and update unprocessableEntity #51815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
reviewed
Jun 17, 2024
| /** | ||
| * Determine if the response was a 422 "Unprocessable Content" response. | ||
| * | ||
| * @return bool |
There was a problem hiding this comment.
Maybe add a @deprecated annotation here.
There was a problem hiding this comment.
Was thinking about the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know you've mentioned on other PRs that you aren't accepting more of these status helpers, but this is a little different because it reflects a change made to HTTP.
It appears that RFC 9110 from June 2022 renamed HTTP 422 from
Unprocessable EntitytoUnprocessable Content, and this change is also reflected in the MDN docs.For this reason I've added
unprocessableContentas a new status helper and updatedunprocessableEntityto point it.Another option you might prefer (for consistency) is to instead add just
unprocessable. The reason for this is that it would matchassertUnprocessable. Happy to update the PR if you'd prefer that.