Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix PasswordBroker constructor docblock #52023

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

seriquynh
Copy link
Contributor

The third parameter of PasswordBroker constructor is $dispatcher (an instance of \Illuminate\Contracts\Events\Dispatcher) but it's currently documented as $users. It might be accidentally copied in the past.

@@ -39,7 +39,7 @@ class PasswordBroker implements PasswordBrokerContract
*
* @param \Illuminate\Auth\Passwords\TokenRepositoryInterface $tokens
* @param \Illuminate\Contracts\Auth\UserProvider $users
* @param \Illuminate\Contracts\Events\Dispatcher $users
* @param \Illuminate\Contracts\Events\Dispatcher|null $dispatcher
Copy link

@marius-mcp marius-mcp Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockblocks for type-hinted properties in function definitions are useless. (unless they bring new info)

@taylorotwell taylorotwell merged commit 466987f into laravel:11.x Jul 5, 2024
28 checks passed
@seriquynh seriquynh deleted the fix-docblock branch July 5, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants