Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Allow MultipleInstanceManager to have studly creators #52030

Conversation

cosmastech
Copy link
Contributor

Manager uses studly case for driver creator names. MultipleInstanceManager just sets the first character of the driver as upper case.

If I have a driver called in_memory, then in my child MultipleInstanceManager, the creator function would look like this:

// Current Implementation
protected function createIn_memoryDriver() { }

// After this PR
protected function createInMemoryDriver() { }

This looks better, brings parity between the two Manager classes, but is not a breaking change because we only check for the studly case method if the ucfirst() formatted method doesn't exist on the class.

@taylorotwell taylorotwell merged commit 38558d9 into laravel:11.x Jul 5, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants