Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, I have a bunch of infrastructural packages that provide a dedicated route file. The entry point of said packages is the
Http
endpoint, and to account for maximum customizability, the routes do not get registered automatically in the correspondingServiceProvider
. Reasoning is simple: theRouter
component makes use of a powerful stacking context, allowing for terrific composability and customization. So, instead of trying to predict every single user-land use case out there, it made much more sense to provide a baseRouteRegistrar
for each package and let the user decide what they want to do with it eventually.Basically, this is how things are done currently:
Then somewhere in the UI where all of the webhooks are composed:
In package tests:
Thanks to this single line of addition, we can now do:
And in the UI:
In tests:
Thanks!