Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Fix docblock for RoutingServiceProvider #52144

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

seriquynh
Copy link
Contributor

The registerPsrRequest and registerPsrResponse methods of RoutingServiceProvider just register binding resolutions and don't actually throw exceptions.

In Laravel app, it only throws exceptions when someone calls ->make(Psr\Http\Message\ServerRequestInterface::class) or ->make(Psr\Http\Message\ResponseInterface::class) without installing the nyholm/psr7 package,

@taylorotwell taylorotwell merged commit 0712996 into laravel:11.x Jul 16, 2024
30 checks passed
@seriquynh seriquynh deleted the fix-docblock branch July 16, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants