[11.x] Prevent bug (🐛) emoji on Collection
/Dumpable
dd
method
#52234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling the
dd
method on aCollection
or a class using theDumpable
trait, it currently outputs a second dump containing just the 🐛 emoji.The emoji is output by symfony/var-dumper when no arguments are passed to the
dd
function.We see it with Collections and
Dumpable
classes because ourdd
methods call their owndump
method, followed by an emptydd
call.A side effect is that the response will return a 200 instead of the usual 500 that the
dd
function returns when there is no previous output, because the firstdump
preventsdd
from setting headers.This PR addresses this by making the
dd
methods just call thedd
function directly. The only downside I can see is if someone has customized theirdump
method, thedd
method will no longer use it.An alternative would be to continue calling the
dump
method, followed by anexit
call. However,dd
has some additional logic to set headers which we might want to reimplement.