[11.x] Use correct pluralization rules in trans_choice for fallback strings #52343
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
trans_choice
function uses the pluralization rules of the preferred language. If the preferred language and the fallback language have different rules, and the key is not found in the preferred language, the fallback language is used but with the pluralization rules of the preferred language, causing unexpected results. See issue #52341 for an example.This PR updates
Translator::localeForChoice()
so that it returns the fallback locale if the preferred language does not have a translation for the given key.