[11.x] Fix Http Client Pool requests that have no response #52393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbroberg
force-pushed
the
fix-http-client-pool
branch
from
66b1047 to
5f17a3e
Compare
Fixes an issue when a HTTP Client Pool is used and a request throws a RequestException and there is no response body. Previously this would still return a Response class, with no response code or body. This now considers it a ConnectionException.
andrewbroberg
force-pushed
the
fix-http-client-pool
branch
from
5f17a3e to
20416a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when a HTTP Client Pool is used and a request throws a RequestException and there is no response body, such as an SSL verify error.
Previously this would still return a Response class, with no response code or body. This now considers it a ConnectionException.
Looks to be a regression of #41412