[11.x] Fix issue where $name variable in non base config file becomes it's key

[rojtjo]

I noticed a bug in one of my apps where it seemed like my published config file was not loaded. After debugging I noticed that
the config file was actually loaded, but under a different key. It looks like this happens when you define a variable named $name in one of your non base config files.

This happens because after requiring the config file, the $name variable is used to call $repository->set($name, $config);.

I fixed this issue by wrapping the require statement in a closure which makes it run in isolation.

[taylorotwell]

Can you give recreation instructions?

[rojtjo]

I've prepared an example at rojtjo/laravel-52738. In the example I've created a config file named foo.php which defines the variable $name at the top and I've also included a failing test.

The issue happens because we inherit all variables from the loadConfigurationFile method. This means that defining any of the variables used in that method, $name in my example, actually redefines them instead.

[taylorotwell]

lol - that's kinda wild.

[rojtjo]

Tell me about it 😅