[11.x] Fix PHP and Artisan binary

[hafezdivandari]

This PR fixes usages of PHP and Artisan binary on different places of the framework.

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[devajmeireles]

@hafezdivandari Are you going ahead with this? This fixes issues caused by the binary path via Herd: /Users/<user>/Library/Application Support/Herd/bin//php. The whitespace in Application Support causes an exception. I'm just wondering if Application can be used here since Concurrency doesn't depend on it in composer.json?

[hafezdivandari]

@devajmeireles yeah I'm gonna fix this if I can control my OCD!

[hafezdivandari]

I'm just wondering if Application can be used here since Concurrency doesn't depend on it in composer.json

It uses Console\Application and I think we already require illuminate/console, because Cocurrency works by calling this command that depends on illuminate/console?

[devajmeireles]

I'm just wondering if Application can be used here since Concurrency doesn't depend on it in composer.json

It uses Console\Application and I think we already require illuminate/console, because Cocurrency works by calling this command that depends on illuminate/console?

This is outdated. Previously you had entered Illuminate\Foundation\Application, but now it looks correct using Illuminate\Console\Application.

[crynobone]

symfony/symfony#52409

There are some internal differences between passing a string and an array to Symfony Process where using an array can be 2x to 4x faster.

[hafezdivandari]

@devajmeireles you're right, that was a typo.

@crynobone good to know, I changed it to pass as an array.

PS: we could use Console\Application::phpBinary() and artisanBinary() everywhere on the framework if they weren't unnecessarily escaped by default!