Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: use qualifyColumn rather than assuming format (#53559)" #53568

Merged
merged 6 commits into from
Nov 19, 2024

Conversation

crynobone
Copy link
Member

@crynobone crynobone commented Nov 19, 2024

CleanShot 2024-11-19 at 08 35 26

Additional changes

  • Add --fail-on-deprecation while running tests option to reduce changes to regression bug in the future.
  • Update $ownerKey to string|null for MorphTo

Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@crynobone crynobone changed the title [11.x] Test Improvements Revert "fix: use qualifyColumn rather than assuming format (#53559)" Nov 19, 2024
@crynobone crynobone marked this pull request as ready for review November 19, 2024 01:06
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
Signed-off-by: Mior Muhammad Zaki <crynobone@gmail.com>
@taylorotwell taylorotwell merged commit 30ddaef into 11.x Nov 19, 2024
32 checks passed
@taylorotwell taylorotwell deleted the 11/deprecations branch November 19, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants