[11.x] Fix the RateLimiter issue when using dynamic keys #53763
Merged
+30
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Laravel v11.29.0, a new modification was introduced to the
RateLimiter
via PR #53177, which provides a fallback key when no unique key is specified. However, this mechanism can cause issues in scenarios where the key is determined dynamically using a closure.For example, when implementing rate limiting based on dynamic
userId
values:In version 11.29.0, the
Limit::by($userId)
method is ignored, and the fallback key is used instead, causing rate limiting records for differentuserId
values to interfere with each other.This fix ensures that if the original limit has a recorded key, it uses the original key as a prefix. For more details, please refer to the PR.