Using throw config of filesystem disks when faking #53779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When production code initializes a storage instance, it relies on the filesystem configuration, which includes a crucial setting called
throw
. Enablingthrow
removes the need for additional checks in the code to verify whether file operations succeeded, as the exceptions themselves provide that information. Moreover, production code often depends heavily on the exceptions thrown.However, the
Storage::fake()
method, by default, creates a storage instance where errors do not trigger exceptions. To align the test environment with production behavior, you must explicitly set thethrow
configuration totrue
each time. Forgetting to do so can lead to issues, including false positives in tests.With this update, the Storage faker will now respect the configuration to set the
throw
value, though it can still be manually overridden.Behavior Before the Change
throw
always defaulted tofalse
, regardless of the configuration.throw
could be set totrue
via the$config
parameter.Behavior After the Change
throw
defaults tofalse
if not specified in the configuration.throw
setting is retrieved from the configuration.throw
can still be explicitly set totrue
via the$config
parameter.