[11.x] Fix client path value in file uploads

[gyaaniguy]

PHP 8.1 introduced the 'full_path' key in $_FILES during file uploads. The purpose is to support Folder uploads.

array(1) {
  ["files"]=>
  array(6) {
    ["name"]=>
    array(2) {
      [0]=>
      string(23) "laravel-svgrepo-com.svg"
    }
    ["full_path"]=>
    array(2) {
      [0]=>
      string(30) "foldit/laravel-svgrepo-com.svg"
    }
  }
}

Symphony handles this. When a new instance of UploadedFile is created, $file['full_path'] ?? $file['name'] is passed to it
originalPath is set to the full value -> /path/filename.txt -> getClientOriginalPath()
originalName is set to the file name after extracting it from the full_path (if needed) // filename.txt

    public function __construct(string $path, string $originalName, ?string $mimeType = null, ?int $error = null, bool $test = false)
    {
        $this->originalName = $this->getName($originalName);
        $this->originalPath = strtr($originalName, '\\', '/');

$file = new UploadedFile($file['tmp_name'], $file['full_path'] ?? $file['name'], $file['type'], $file['error'], false);

Laravel doesn't handle this change.

InteractsWithInput.php file:
convertUploadedFiles() is defined. "Convert the given array of Symfony UploadedFiles to custom Laravel UploadedFiles."

convertUploadedFiles calls UploadedFile::createFromBase($file). This is where the Issue lies (UploadedFile.php ln 144)

A new instance of uploadedFile is created using the 'getClientOriginalName' causing us to lose the 'full_path' value. Which was stored in getClientOriginalPath()

  public static function createFromBase(SymfonyUploadedFile $file, $test = false)
    {
        return $file instanceof static ? $file : new static(
            $file->getPathname(),
            $file->getClientOriginalName(), //problem
            $file->getClientMimeType(),
            $file->getError(),
            $test
        );
    }

Note: path here is not the temporary path. Not the uploadedTo path. But the original path sent by the client in the full_path key.

My fix: is to use getClientOriginalPath() instead. I think it should be okay. Since symfony extracts the originalname from the full_path.

This is my first attempt of such a PR. Please do tell if I have missed anything.

Thank you!

[gyaaniguy]

hmm it seems my changes are dependent on http-foundation : 7.2.0 .
Whereas the tests lock the version to 7.0.3
Locking symfony/http-foundation (v7.0.3)

I am gonna try updating composer.json. Not sure if I should though..

Edit: well updating composer and fixing styling, seems to have fixed the tests as well.