Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.0] Add auto incrementing id column to migrations #7249

Closed
wants to merge 1 commit into from
Closed

[5.0] Add auto incrementing id column to migrations #7249

wants to merge 1 commit into from

Conversation

alexwhitman
Copy link
Contributor

As an alternative to #7244 this adds an auto incrementing id column to the migrations table. This gives the table a primary key but doesn't have any issues around string index length.

@ravanscafi
Copy link

Why should it be included? There's no relation between migrations and other tables.

@RomainLanz
Copy link

@rscafi Just look at the linked pull ;)

@taylorotwell
Copy link
Member

We actually tried this once and it caused issues.

@alexwhitman
Copy link
Contributor Author

@taylorotwell Adding an id column caused problems? Are you not getting mixed up with indexing the migration column which can cause issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants