Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #1488 : Focused line gets hightlighted [remove .vjs-tree-node:hover] #1492

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

srennou
Copy link
Contributor

@srennou srennou commented Aug 22, 2024

Hi,
This is my first-ever pull request, and I’m excited to contribute! 🎉 even with the smallest change.

In this PR, I’ve addressed the issue mentioned in Issue #1488. The hover effect on table rows in the Horizon dashboard could be distracting or unnecessary, so I’ve removed ".vjs-tree-node:hover" from the CSS "./dist/app.css". This change should help create a cleaner and more focused user experience.

Thank you for considering my contribution!

@crynobone crynobone linked an issue Aug 23, 2024 that may be closed by this pull request
@driesvints
Copy link
Member

@srennou this unfortunately won't work as assets are auto compiled. As soon as this is merged assets will re-compile and this will be undone. We'll need to find a CSS solution to this I believe.

@srennou
Copy link
Contributor Author

srennou commented Aug 23, 2024

hello ,
@driesvints okey thank you ill fix that and make an other PR

@srennou
Copy link
Contributor Author

srennou commented Aug 23, 2024

hi ,
i've added
&:hover { background-color: unset; }
under the .vjs-tree-node in the file "./resources/sass/syntaxhighlight.scss" to overrite the hover effect cause based on "./vite.config.js" the "./dist/app.css" is not a generated asset please correct me if i'm wrong .
Thank you.

@taylorotwell taylorotwell merged commit 533e552 into laravel:5.x Aug 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Focused line gets hightlighted
3 participants