[2.0] Use router-link on recent jobs's failed jobs link #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eduPHP
changed the title
driesvints
changed the title
|
We're not using this anywhere else in the library atm plus the config option was recently removed because its implementation was incomplete: de6b0ca |
|
Are you not using router-link anywhere? I am not sure why this can't be merged |
|
@swalker2 Ah sorry, seems I was mistaken. We do indeed use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So, because of some limitations on my production server I had to use this horizon.uri config option and got it working after some tweaking.
This PR fixes one link that wasn't using router-link and was not working for me.