Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Adjust auto scaling to always use the max processes #627

Merged
merged 1 commit into from
Jul 2, 2019

Conversation

themsaid
Copy link
Member

@themsaid themsaid commented Jul 2, 2019

As reported in #486

If the max. number of processes is 4, while you're balancing 3 queues. The number of workers per processes needed per queue will be 1.3. When using round() Horizon will assign 1 process per queue and then it's done.

However if we use ceil() Horizon will assign 1 process per queue and then it'll assign a process for the first queue since each queue will require 2 instead of 1.

  • 4 / 3 = 1.3
  • round(1.3) = 1 (That's the current case)
  • ceil(1.3) = 2 (That's what this PR changes)

@driesvints driesvints changed the title Adjust auto scaling to always use the max processes [3.0] Adjust auto scaling to always use the max processes Jul 2, 2019
@taylorotwell taylorotwell merged commit 6b2e912 into laravel:3.0 Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants