[3.x] Another way for tags displaying & collapsable panels #754
+35
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will solve #388 |
driesvints
approved these changes
Feb 4, 2020
|
@Cannonb4ll thanks for all your work on these prs! |
|
@driesvints No problem, I have a lot more idea's actually. Also, in favor of the earlier comment about too long tags. Wouldn't horizontal navigation solve this so the full content is benefitted? (We could also make this configurable) |
|
I'm not sure. It looks good but it would be different from Telescope that way. |
|
Yes true, I will leave that as it is. |
|
@Cannonb4ll Instead of using View detail as a hyperlink, we could use the Job name as a hyperlink and UX will be similar to failed job listing page. |
|
Great work @Cannonb4ll -> Very handy additions in the 3.6 update! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I showed in PR #751 the index in this PR will now display a max of 3 tags and a small label if there are more with (53 more).
Then in the job detail view from PR #751 I display the tags at the bottom in vue-json-pretty.
I have also taken the opportunity to make the panels collapsable in the job detail so whenever there's a lot of data you can collapse that.
Screens to show what I mean: