Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server reloads unnecessarily when linked files to public dir changes #202

Closed
myckhel opened this issue Apr 15, 2021 · 1 comment
Closed

Comments

@myckhel
Copy link

myckhel commented Apr 15, 2021

  • Octane Version: 0.2.0
  • Laravel Version: ^8.37
  • PHP Version: 8.0.2
  • Server: Swoole

Description:

based on the previously closed issue #118

During watch mode and when media files are created the server detects the changes and reload the server each time.
would it be a good idea to specify directories to be ignored during watch mode?
so that server don't reload when uncared files changes.

and later comment #118 (comment)

This pull request didn't solve the unnecessary server reload issue.

For example i have linked some folders into the public dir (public/images)
when new images are added the watcher detects changes from public/images dir and reloads the server.

With the pull request created there is still no option to ignore some nested folders.

I will try to make a pull request for unwatch config.

i hope the pull request will be considered.

Tried a pull request #201
but unfortunately it was closed with no clear reason.

I hope someone can see this issue and try to solve it.

I have tried and my effort have not been considered.

@driesvints
Copy link
Member

It seems like Taylor doesn't wants to change this atm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants