Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Octane Server Restarts When Media Files Uploaded. #246

Closed
myckhel opened this issue Apr 28, 2021 · 6 comments
Closed

[BUG]: Octane Server Restarts When Media Files Uploaded. #246

myckhel opened this issue Apr 28, 2021 · 6 comments
Assignees

Comments

@myckhel
Copy link

myckhel commented Apr 28, 2021

  • Octane Version: v0.3.2
  • Laravel Version: v8.38.0
  • PHP Version: v8.0
  • Server: Swoole

Description:

During watch mode and when media files are uploaded, the server restarts and which is an unwanted behaviour.

Screenshot 2021-04-28 at 11 38 12

I have opened this issue several times (#202, #118) and i think this is a bug and the issue should be left opened until its resolved.

Steps To Reproduce:

Add images dir link to filesystem config

// config/filesystem.php
'links' => [
        public_path('storage') => storage_path('app/public'),
        public_path('images') => base_path('images'),
    ],

Link dir to public dir

images dir to public: php artisan storage:link

create/edit/delete file from images dir

OR

modify public/vendor, public/build folders which are frontend generated folders.

@nunomaduro nunomaduro self-assigned this Apr 28, 2021
@kamlesh-php
Copy link

may be we need exclude DIR like

'watch' => [

this have

@nunomaduro
Copy link
Member

@myckhel @kamlesh-php Can you try this? #247.

@nunomaduro
Copy link
Member

@myckhel Also, please ensure you are running the latest version of Octane.

@myckhel
Copy link
Author

myckhel commented Apr 28, 2021

well @nunomaduro i have tested the master branch and updated my octane.php but the changes will only apply to dir with 2 levels deep.
so 2 levels deep will actually not work for some of us that uses etc: laravel-medialibrary which stores files in 2,3 or more levels deep.

@nunomaduro
Copy link
Member

@myckhel That's not true. It's a glob expression that covers all the directories specified recursively.

@myckhel
Copy link
Author

myckhel commented Apr 28, 2021

@nunomaduro sorry for my bad comment.
because my server still reloads when modified linked images dir and that made me taught the expression only covers 2 dir since i have no knowledge in glob expression.

i will try to see why my linked images dir is reloading the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants