[2.x] Fix inter test dependencies #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driesvints
pushed a commit
that referenced
this pull request
Jun 24, 2024
* Flush container between tests * Ensure app is available when needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes some inter-test dependencies. Currently, certain tests depend on other test to be run first and can not be run individually.
Specifically, these tests rely on the container singleton to have been created by another test and to be shared between tests.
I noticed this issue when creating another PR and some unrelated tests randomly started failing with the change.
You can see these failures by running
phpunit --process-isolationagainst the2.xbranch.You can see the failing tests, in all their glory, in this test run (https://github.com/laravel/octane/actions/runs/9573937368/job/26396301757) which is tied to the commit that flushes the container between tests (326bdc6)
This PR includes the container flushing and individual test fixes.