[9.x] Implement personal access client config #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #1256 which implements secret hashing in a proper way for personal access clients. This will require some additional upgrade steps for the users unfortunately but at least this allows proper hashing for all client types. People who have already hashed their personal access client secrets will need to create new personal access clients with new secrets.
Ideally in a follow-up pr for this, we'll get rid of the required
Passport::personalAccessClientIdandPassport::personalAccessClientSecretcalls so the developer doesn't needs to implement these anymore. But that'll have to be for a next major version release.Fixes #1252