[13.x] Fix user-token relations #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
| return $provider; | ||
| } | ||
| } | ||
|
|
||
| return null; | ||
| throw new LogicException('Unable to determine authentication provider for this model from configuration.'); |
There was a problem hiding this comment.
So what should they do in this case?
There was a problem hiding this comment.
This should never happen, the authenticatable model should have a provider registered on auth configuration as we instruct the developer when installing Passport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$user->getProviders()has been added recently on PR [13.x] Configure the user provider for PAT #1768, this method actually must not returnnullin a healthy environment / configuration. Also, it is not possible to use Passport with adatabaseprovider. This PR fixes these 2 situations on this method.Usermodel by default) andTokenmodel depends on the client'sprovider. This PR makes sure we are retrieving the tokens associated with the right authenticable model and adds integration tests for this.user->tokens()relation is morphable, so we know which model is the owner of the key, on Passport we should check the client'sproviderto know which model is the owner of the key.