Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retrieve primary key identifier in AuthCodeRepository & TokenRepository #1786

Conversation

JorrinKievit
Copy link

@JorrinKievit JorrinKievit commented Sep 24, 2024

I am using custom table and column names for all Passport created tables. Everything works using the class overrides, except for these particular queries in AuthCodeRepository and TokenRepository. I use mutators to rewrite some model attributes, but that was not working for both. Now this query respects the set primary key on the authCode & token model instead. I am fairly new to Laravel, so there might be a better solution 😄.

This code also exists in 13.x, so I guess this should be merged into 13.x too?

@JorrinKievit JorrinKievit changed the title retrieve primary key identifier in AuthCodeRepository retrieve primary key identifier in AuthCodeRepository & TokenRepository Sep 24, 2024
@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@JorrinKievit JorrinKievit deleted the bugfix/auth-code-use-dynamic-primary-key branch September 24, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants