Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page up & down key inputs #179

Merged
merged 1 commit into from
Dec 30, 2024
Merged

Conversation

CamKem
Copy link
Contributor

@CamKem CamKem commented Dec 29, 2024

This pull request includes updates to the Key class in add new key constants for navigation.

Key constants added:

  • PAGE_UP constant with the value "\e[5~"
  • PAGE_DOWN constant with the value "\e[6~"

These escape sequences align with the most common VT100/ANSI emulation in modern terminal environments and are particularly useful for handling Page Up/Down navigation. For reference please GNU documentation on input translation in emulation of the VT100

Copy link
Member

@jessarcher jessarcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! It feels a little weird to include these constants but not use them internally, but it's cool that folks are extending Prompts in all sorts of interesting ways and it's nice to have a single source of truth for this stuff.

@taylorotwell taylorotwell merged commit 749395f into laravel:main Dec 30, 2024
10 checks passed
@CamKem CamKem deleted the feat/page-keys branch December 31, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants