Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Cleanup phpunit.xml #95

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

Jubeki
Copy link
Contributor

@Jubeki Jubeki commented Oct 3, 2024

The develop branch requires PHP 8.1, therefor the phpunit.xml can be simplified.

@crynobone
Copy link
Member

I reserving this changes as we might need to introduce tests specifically for 8.4, will revisit this once we finalise PHP 8.4 supports

@crynobone crynobone marked this pull request as draft October 3, 2024 09:42
@crynobone crynobone changed the title [develop] Cleanup phpunit.xml [2.x] Cleanup phpunit.xml Oct 3, 2024
@Jubeki
Copy link
Contributor Author

Jubeki commented Nov 8, 2024

@crynobone I will also open up this for review, because there were no PHP 8.4 specific tests added.

@Jubeki Jubeki marked this pull request as ready for review November 8, 2024 16:29
@taylorotwell taylorotwell merged commit 38cb843 into laravel:develop Nov 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants