Move cache read inside VarDumper handler to avoid cache call during p…

…ackage discovery/composer install calls (#1025)
laravel · Mar 8, 2021 · 897d2e0 · 897d2e0
1 parent 4d4a2f7
commit 897d2e0
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/Watchers/DumpWatcher.php b/src/Watchers/DumpWatcher.php
@@ -40,14 +40,14 @@ public function __construct(CacheFactory $cache, array $options = [])
      */
     public function register($app)
     {
-        if (! $this->cache->get('telescope:dump-watcher')) {
-            return;
-        }
-
         $htmlDumper = new HtmlDumper();
         $htmlDumper->setDumpHeader('');
 
         VarDumper::setHandler(function ($var) use ($htmlDumper) {
+            if (! $this->cache->get('telescope:dump-watcher')) {
+                return;
+            }
+
             $this->recordDump($htmlDumper->dump(
                 (new VarCloner)->cloneVar($var), true
             ));