Skip to content

Commit

Permalink
Fix PHPUnit 8 warnings
Browse files Browse the repository at this point in the history
The `assertArraySubset` method has been deprecated and the
`assertContains` method should no longer be used with strings.

This alternatives suppress the warnings.
  • Loading branch information
roberto-aguilar committed Apr 10, 2019
1 parent f5d5bb3 commit a669608
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 4 deletions.
2 changes: 1 addition & 1 deletion tests/Watchers/DumpWatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,6 @@ public function test_dump_watcher_register_entry()
$entry = $this->loadTelescopeEntries()->first();

$this->assertSame(EntryType::DUMP, $entry->type);
$this->assertContains($var, $entry->content['dump']);
$this->assertStringContainsString($var, $entry->content['dump']);
}
}
4 changes: 3 additions & 1 deletion tests/Watchers/EventWatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ public function test_event_watcher_stores_payloads()
$this->assertSame(EntryType::EVENT, $entry->type);
$this->assertSame(DummyEvent::class, $entry->content['name']);
$this->assertArrayHasKey('data', $entry->content['payload']);
$this->assertArraySubset(['Telescope', 'Laravel', 'PHP'], $entry->content['payload']['data']);
$this->assertContains('Telescope', $entry->content['payload']['data']);
$this->assertContains('Laravel', $entry->content['payload']['data']);
$this->assertContains('PHP', $entry->content['payload']['data']);
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Watchers/MailWatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ public function test_mail_watcher_registers_entry()
$this->assertSame(['bcc@laravel.com'], array_keys($entry->content['bcc']));
$this->assertSame('Check this out!', $entry->content['subject']);
$this->assertSame('Telescope is amazing!', $entry->content['html']);
$this->assertContains('Telescope is amazing!', $entry->content['raw']);
$this->assertStringContainsString('Telescope is amazing!', $entry->content['raw']);
$this->assertEmpty($entry->content['replyTo']);
}
}
2 changes: 1 addition & 1 deletion tests/Watchers/NotificationWatcherTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public function test_notification_watcher_registers_entry()
$this->assertSame(EntryType::NOTIFICATION, $entry->type);
$this->assertSame(BoomerangNotification::class, $entry->content['notification']);
$this->assertSame(false, $entry->content['queued']);
$this->assertContains('telescope@laravel.com', $entry->content['notifiable']);
$this->assertStringContainsString('telescope@laravel.com', $entry->content['notifiable']);
$this->assertSame('mail', $entry->content['channel']);
$this->assertNull($entry->content['response']);
}
Expand Down

0 comments on commit a669608

Please sign in to comment.