Merge pull request #720 from erikgaal/patch-dont-resume-recording-wit…

…h-sync-jobs

Prevent resuming recording when processing sync job

src/ListensForStorageOpportunities.php

@@ -53,10 +53,12 @@ protected static function storeEntriesBeforeTermination($app)
      */
     protected static function storeEntriesAfterWorkerLoop($app)
     {
-        $app['events']->listen(JobProcessing::class, function () {
-            static::startRecording();
+        $app['events']->listen(JobProcessing::class, function ($event) {
+            if ($event->connectionName !== 'sync') {
+                static::startRecording();
 
-            static::$processingJobs[] = true;
+                static::$processingJobs[] = true;
+            }
         });
 
         $app['events']->listen(JobProcessed::class, function ($event) use ($app) {

tests/Telescope/TelescopeTest.php

@@ -3,6 +3,8 @@
 namespace Laravel\Telescope\Tests\Telescope;
 
 use Laravel\Telescope\Telescope;
+use Illuminate\Contracts\Bus\Dispatcher;
+use Illuminate\Contracts\Queue\ShouldQueue;
 use Laravel\Telescope\Tests\FeatureTestCase;
 use Laravel\Telescope\Watchers\QueryWatcher;
 use Laravel\Telescope\Contracts\EntriesRepository;
@@ -70,4 +72,37 @@ public function after_recording_callback_can_store_and_flush()
 
         $this->assertCount(1, Telescope::$entriesQueue);
     }
+
+    /**
+     * @test
+     */
+    public function dont_start_recording_when_dispatching_job_synchronously()
+    {
+        Telescope::stopRecording();
+
+        $this->assertFalse(Telescope::isRecording());
+
+        $this->app->get(Dispatcher::class)->dispatch(
+            new MySyncJob('Awesome Laravel')
+        );
+
+        $this->assertFalse(Telescope::isRecording());
+    }
+}
+
+class MySyncJob implements ShouldQueue
+{
+    public $connection = 'sync';
+
+    private $payload;
+
+    public function __construct($payload)
+    {
+        $this->payload = $payload;
+    }
+
+    public function handle()
+    {
+        //
+    }
 }