Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dump] DumpCollector can be slow with large amount of data #682

Closed
barryvdh opened this issue Aug 13, 2019 · 1 comment
Closed

[Dump] DumpCollector can be slow with large amount of data #682

barryvdh opened this issue Aug 13, 2019 · 1 comment

Comments

@barryvdh
Copy link
Contributor

The DumpCollector works by continuously loading the Dump entries. There are 50 dump entries loaded on each request by default, which are refreshed every 2 seconds.
For the other collectors, there is a ?take=1 parameter which is compared to the last entry. Perhaps that should be done with Dump also?

And besides that, when dumping large object, Dump can become very heavy. Try generating 50 dumps of app() and loading the page (not very real-life, but demonstrates the problem -> generating 10+MB of HTML and refreshing that every 2 seconds.

Would the Dump screen perhaps make more sense as a normal preview page?

@barryvdh
Copy link
Contributor Author

Or, if you want to create a 'streaming dump server' kind-of-thing, maybe create a regular index/preview page like the rest, but add a 'streaming' page (the current Dump screen) which will only load the last entry and add new entries on the fly, instead of loading alle of them from the API directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant