Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize dump #683

Merged
merged 5 commits into from
Aug 14, 2019
Merged

Optimize dump #683

merged 5 commits into from
Aug 14, 2019

Conversation

barryvdh
Copy link
Contributor

This shuld fix #682 and partially fix #611 (or at least give the user some information about it).
Addition could be to specify a cache driver in config/telescope, so that the Telescope driver could be different (eg. if you want to work with the array driver locally).

This shows an error when something goes wrong (eg. the wrong cache driver in this instance).
It also changes the loading of entries to check 1 entry and only load the rest when something changed (just like the rest of the Index screens).

@barryvdh barryvdh mentioned this pull request Aug 14, 2019
@taylorotwell taylorotwell merged commit 7f6112c into laravel:master Aug 14, 2019
@barryvdh barryvdh deleted the optimize-dump branch August 14, 2019 13:32
@driesvints
Copy link
Member

Are there breaking changes here? If not then shouldn't this be sent to 2.0 branch instead?

@barryvdh
Copy link
Contributor Author

To be honest, I'm not really sure which branch is correct. I saw the latest development happen in the master branch, and as far as I can tell, none of them are breaking changes. So not sure why this branch is 3.0 instead of 2.1, or why there is a seperate branch. Looking at it now, they are only fixes / small changes: https://github.com/laravel/telescope/compare/master

@driesvints
Copy link
Member

@barryvdh 3.0 hasn't been released yet. All our repos follow the same branching system where the master is always the next major version. Backwards compatible new features can always be sent to the current release branch: https://laravel.com/docs/5.8/contributions#which-branch

@barryvdh
Copy link
Contributor Author

Okay, then I think you can merge all commits from master into 2.0 and I'll update my open PR's to 2.0 after that.

@driesvints
Copy link
Member

@barryvdh I got a bit stuck with cherry-picking so feel free to backport yourself if you want this in the next 2.x release.

@barryvdh
Copy link
Contributor Author

Okay, which one do you not want to include on 2.0? Looking through the commits, the only one that might be unneccesary is your dev-master update, but that doesn't matter on branches that are not dev-master, right?

@driesvints
Copy link
Member

@barryvdh I wanted to backport but the cherry-picking just failed for me. So didn't want to lose too much time on this. Just feel free to send this in yourself.

@barryvdh
Copy link
Contributor Author

@driesvints so #686 ?

This was referenced Aug 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants