Add a new "Clear Entries" button at the top of Telescope #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged. Added confirmation - reloaded page entirely instead of managing state in JS. |
|
Thanks a lot Taylor ! |
|
@AlexDanault Why didn't this go to branch 4.x? |
|
@emargareten At first I was thinking this is a new feature so I followed the doc and used master, but now I realise that it is fully backward compatible and should have gone on 4.x . Maybe @taylorotwell can move it to 4.x so we get this cool feature sooner ? |
|
@AlexDanault Yes feel free to send to 4.x |
AlexDanault
added a commit
to AlexDanault/laravel-telescope
that referenced
this pull request
Jul 11, 2021
|
Done, see #1091 . |
taylorotwell
pushed a commit
that referenced
this pull request
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new "Clear Entries" button at the top of the layout (after the Pause Recording button).
Clicking it triggers a call the the backend which clears the entries in the database and also wipes the current in-memory entries of the Vue app.
The SVG icon comes from zondicons to match the other telescope icons.
This feature has been touroughly tested and works both when new entries are loaded automatically and when they are not.
Any comments, questions, code review, bugs of missing features would be very welcome.
Personally, as a heavy telescope user, this would be a very welcome feature, and a nice addition to the great tool that telescope is.
When debuging, this new button is much quicker than having to leave your curren window (telescope), go the terminal, call artisan telescope:clear, go back to telescope and refresh the window.
Thanks !