-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.x] Update to bootstrap 5.1 and drop jQuery #1179
[5.x] Update to bootstrap 5.1 and drop jQuery #1179
Conversation
https://getbootstrap.com/docs/5.1/migration/#content-reboot-etc `Links are underlined by default (not just on hover), unless they’re part of specific components.`
470e696
to
3aef2a3
Compare
Converting this to draft while @themsaid reviews it. Please mark as ready once reviewed. |
Fix overflowing text in json pretty output
@themsaid the overflowing text in the json output is also a problem on the 4.x branch. Fixed it. I found one missing utility class that had the wrong prefix. The navigation is working fine on my side, can you try it again. After switching to the new branch I had to do a full reload with cache invalidation in the browser. |
@themsaid this is new since bootstrap v5 https://getbootstrap.com/docs/5.1/content/tables/ every table has a border under the table-head. Should I remove it? |
Yes please remove that. |
This reverts commit 572a58d.
We're very sorry @mmachatschek but we had to revert this PR because it majorly conflicted with #1295 in almost every Vue file. We decided to revert this one so we could merge 4.x into 5.x for preparation of Laravel v11 support. We're definitely still open to this PR but we'll need a fresh one. |
This PR updates bootstrap from 4.6 to 5.1 and applies the migration steps from https://getbootstrap.com/docs/5.1/migration/
Additionally I managed to remove jQuery and replace its usage with vanilla JS.