Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug watching invokeable object events #1250

Merged
merged 3 commits into from
Sep 12, 2022
Merged

Fix bug watching invokeable object events #1250

merged 3 commits into from
Sep 12, 2022

Conversation

ziadoz
Copy link
Contributor

@ziadoz ziadoz commented Sep 11, 2022 •
edited
Loading

Listening to an event using an invokeable object or an anonymous invokeable objects throws an exception, so I've fixed it and added some test coverage.

Laravel\Telescope\Watchers\EventWatcher::formatClosureListener(): Argument #1 ($listener) must be of type Closure, App\Providers\MyListener given, called in /var/www/html/vendor/laravel/telescope/src/Watchers/EventWatcher.php on line 96

Laravel\Telescope\Watchers\EventWatcher::formatClosureListener(): Argument #1 ($listener) must be of type Closure, class@anonymous given, called in /var/www/html/vendor/laravel/telescope/src/Watchers/EventWatcher.php on line 96

@ziadoz ziadoz marked this pull request as draft September 12, 2022 07:52
@ziadoz ziadoz marked this pull request as ready for review September 12, 2022 08:57
@taylorotwell taylorotwell merged commit c414762 into laravel:4.x Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziadoz @taylorotwell