Add view collector #679
Merged
Add view collector #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you screenshot what it looks like? |
|
I've updated the path to strip the base path, and filters some data that is always present. Index: Request tab: |
|
The icons are Zondicons it looks like: https://www.zondicons.com/icons.html You can try to pick one you think is appropriate. |
|
Maybe |
|
Sure, updated it. |
|
Thanks? Don't forget this still needs a compilation of assets. |
This was referenced Aug 20, 2019
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a Watcher for the Views/templates.
The RequestWatcher logs the latest view, but not any other views/subviews which might be useful.
The
extractDataFromViewcould be re-used, but I think that would generate a lot of data / cost in CPU.Icon is the same as Model, not sure where the SVG's are coming from to pick one.
Fixes #677
(Assets are not compiled because of potential merge conflicts)