Add information about view composers #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds information about used view composers. Since view composers are a bit magical and for people sometimes hard to figure out where data in their views is coming from. It seems useful to have this information available in telescope.
It’s showing information for view composers and view creators. In the index pages we only talk about composers though. I’ve followed the Laravel docs in this where the part about view creators is also a sub-section of view composers. In the composer detail screen it’s possible to see whether it’s a creator or composer.
A test is added with some example view files. As there currently was no test for the
ViewWatcher.Screenshots of the functionality
The way the view is shown in a table is slightly changed as views from vendor directories (with long names) would make the row jump out of the table, see example:
