Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly Implode Nested(Array) Notification Routes To Fix Array To String Conversion Exception #778

Merged
merged 3 commits into from
Nov 23, 2019
Merged

Properly Implode Nested(Array) Notification Routes To Fix Array To String Conversion Exception #778

merged 3 commits into from
Nov 23, 2019

Conversation

srinathreddydudi
Copy link
Contributor

When sending an anonymous notification with a string route, The entries are logged successfully. But when using an array of routes, There is an array to string conversion exception in the notification watcher.

// This works well
Notification::route('mail', 'telescope@laravel.com')->notify( new SomeNotification() );

// This throws an array to string conversion exception
Notification::route('mail', ['telescope@laravel.com'])->notify( new SomeNotification() );

Screenshot from 2019-11-22 21-54-00

Screenshot from 2019-11-22 21-55-15

I have added a test case which verifies working of the new change with array routes.

This is my first time contributing to an open source project. Please guide me in the right direction if i did not follow any standards.

@taylorotwell taylorotwell merged commit 05af183 into laravel:2.0 Nov 23, 2019
@srinathreddydudi srinathreddydudi deleted the nested-notification-routes branch November 24, 2019 04:42
@iSWORD
Copy link

iSWORD commented Dec 2, 2019

was just about to submit a PR to fix this. when is a new release coming out with this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants