Update "fetch-share-url" to pull correct URL for HTTPS tunnels, not just HTTP #1460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rana01645 This is very helpful! Do you know why you're getting an HTTPS tunnel instead of HTTP, by chance? |
mattstauffer
changed the title
|
To be honest, I don't know why we want the HTTP version locally, but I've run into this problem before too, so I'm going to merge it with a hope and a prayer that there's nothing bad about pulling in the HTTPS version when that's all we have. |
mattstauffer
added a commit
that referenced
this pull request
Dec 21, 2023
|
@mattstauffer I also don't know why I'm getting only the HTTPS, we use It could be something related to ngrok maybe! Thanks for merging this pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time I'm using
valet fetch-share-urlit's giving this errorThere is no Ngrok tunnel established for ***********.testDuring deep diving, I found that my tunnel is using HTTPS protocol which is why it's unable to get the shared URL!
This pull request will solve this issue!