Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for PHP 8.4 #1499

Merged
merged 2 commits into from
Nov 25, 2024
Merged

Add support for PHP 8.4 #1499

merged 2 commits into from
Nov 25, 2024

Conversation

SupianIDz
Copy link
Contributor

@SupianIDz SupianIDz commented Nov 17, 2024

Include PHP 8.4 in the list of supported PHP versions in both Valet Brew and GitHub Actions test matrix. This ensures compatibility and testing for the latest PHP release.


This fixes the Unable to determine linked PHP when parsing '8.4' issue when using Valet using PHP version 8.4

Screenshot 2024-11-17 at 20 54 10

Include PHP 8.4 in the list of supported PHP versions in both Valet Brew and GitHub Actions test matrix. This ensures compatibility and testing for the latest PHP release.
@drbyte
Copy link
Contributor

drbyte commented Nov 17, 2024

Agreed.

We can update the LATEST_PHP_VERSION constant below it after 8.4 is officially released.

/cc @mattstauffer

@SupianIDz
Copy link
Contributor Author

PHP 8.4 is out now, so when will this be merged?

cc @mattstauffer

@drbyte
Copy link
Contributor

drbyte commented Nov 23, 2024

NOTE: As a temporary workaround, you can edit your ~/.composer/vendor/laravel/valet/cli/Valet/Brew.php and add PHP 8.4 to the top of the supported-versions array.

Later, after this is merged, you can remove the edit. Or when you run composer global update it will ask you if you want to "stash" or "replace" your edits. Choose "Replace" (or whatever means to delete your temporary edits).

@RobertBoes
Copy link
Contributor

@mattstauffer @taylorotwell could this get a review? Herd had support for 8.4 alpha for ages, while also being built on top of Valet. Now that 8.4 is released it would be nice to have support for it in Valet, so people can test and upgrade.

@mattstauffer mattstauffer merged commit 07432a9 into laravel:master Nov 25, 2024
5 checks passed
@mattstauffer mattstauffer mentioned this pull request Nov 25, 2024
@mattstauffer
Copy link
Collaborator

@SupianIDz Thanks for the PR! Apologies for the delay, my GitHub inbox is an absolute garbage fire so a week is actually a pretty fast turnaround for me these days :)

@drbyte thanks as always for the review! And the workaround suggestion for folks.

@RobertBoes Herd was based on Valet, but does not contribute back to Valet. You can expect features and timelines to differ between the two.

Herd is a paid project, maintained by people paid to work on it. Valet is free, maintained by volunteers--mainly @drbyte and me, and also some other wonderful people who take their time to submit and review PRs.

As I mentioned above, I wish I had gotten to this one faster. But comparing Valet and Herd is not going to be a productive strategy. :)

@RobertBoes
Copy link
Contributor

@mattstauffer Right, that makes sense, sorry I worded it a bit shitty 😅

Thanks for the clarification, I was under the impression it just used Valet (since that's present in the binary file of Herd) and Valet contains a bit of code to account for Herd.

@mattstauffer
Copy link
Collaborator

@RobertBoes that's totally understandable!

That was the original plan, but seems to not be the direction the Herd team chose to go in the end. So I closed my PR to make that possible and they are now entirely separate codebases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants