-
Notifications
You must be signed in to change notification settings - Fork 698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for PHP 8.4 #1499
Add support for PHP 8.4 #1499
Conversation
Include PHP 8.4 in the list of supported PHP versions in both Valet Brew and GitHub Actions test matrix. This ensures compatibility and testing for the latest PHP release.
Agreed. We can update the /cc @mattstauffer |
PHP 8.4 is out now, so when will this be merged? |
NOTE: As a temporary workaround, you can edit your Later, after this is merged, you can remove the edit. Or when you run |
@mattstauffer @taylorotwell could this get a review? Herd had support for 8.4 alpha for ages, while also being built on top of Valet. Now that 8.4 is released it would be nice to have support for it in Valet, so people can test and upgrade. |
@SupianIDz Thanks for the PR! Apologies for the delay, my GitHub inbox is an absolute garbage fire so a week is actually a pretty fast turnaround for me these days :) @drbyte thanks as always for the review! And the workaround suggestion for folks. @RobertBoes Herd was based on Valet, but does not contribute back to Valet. You can expect features and timelines to differ between the two. Herd is a paid project, maintained by people paid to work on it. Valet is free, maintained by volunteers--mainly @drbyte and me, and also some other wonderful people who take their time to submit and review PRs. As I mentioned above, I wish I had gotten to this one faster. But comparing Valet and Herd is not going to be a productive strategy. :) |
@mattstauffer Right, that makes sense, sorry I worded it a bit shitty 😅 Thanks for the clarification, I was under the impression it just used Valet (since that's present in the binary file of Herd) and Valet contains a bit of code to account for Herd. |
@RobertBoes that's totally understandable! That was the original plan, but seems to not be the direction the Herd team chose to go in the end. So I closed my PR to make that possible and they are now entirely separate codebases. |
Include PHP 8.4 in the list of supported PHP versions in both Valet Brew and GitHub Actions test matrix. This ensures compatibility and testing for the latest PHP release.
This fixes the
Unable to determine linked PHP when parsing '8.4'
issue when using Valet using PHP version 8.4