Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TextSlice; Lark can now parse/lex a text-slice #1452

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

erezsh
Copy link
Member

@erezsh erezsh commented Aug 19, 2024

Based on previous PR by MegaIng. See #1429

This comment was marked as outdated.

@erezsh erezsh requested a review from MegaIng August 19, 2024 11:07
@erezsh
Copy link
Member Author

erezsh commented Aug 19, 2024

@MegaIng I basically used your code, with very little changes.

I didn't encounter any complications, so maybe I missed it.

Copy link
Member

@MegaIng MegaIng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! No comments on the implementation itself. (It is after all a version of my implementation :-)) However, I think a bit of documentation would be nice:

  • Make sure TextSlice appears in the doc pages
  • Add a docstring for it
  • Mention the ability to deal with TextSlice in the parsing methods, and especially mention that lexer='dynamic' can't (yet) deal with it.

@erezsh
Copy link
Member Author

erezsh commented Sep 15, 2024

Added. Let me know if I forgot to mention something.

@erezsh
Copy link
Member Author

erezsh commented Sep 24, 2024

If no one objects, I will merge this soon. @MegaIng

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants