Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove taint mode from critic test. #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

plicease
Copy link

I am not sure what the -T should be necessary for this test, and I get this
error with it:

t/critic.t ............ Insecure dependency in chdir while running with -T switch at /home/ollisg/perl5/perlbrew/perls/perl-5.29.3/lib/5.29.3/File/Find.pm line 375.
t/critic.t ............ Dubious, test returned 2 (wstat 512, 0x200)

While I was in here, I also added stopwords to the POD which was preventing the test from passing.

#   Failed test 'Test::Perl::Critic for "lib/Test/PerlTidy.pm"'
#   at /home/ollisg/.perlbrew/libs/perl-5.29.3@dev/lib/perl5/Test/Perl/Critic.pm line 121.
# 
#   Check the spelling in your POD: Hmmm perltidy cvs perltidyrc subdirectories listref canonified pre von der Leszczynski perl at line 1, near 'package Test::PerlTidy;'.
#   Documentation::PodSpelling (Severity: 1)
#     Did you write the documentation? Check.

I am not sure what the -T should be necessary for this test, and I get this
error with it:

t/critic.t ............ Insecure dependency in chdir while running with -T switch at /home/ollisg/perl5/perlbrew/perls/perl-5.29.3/lib/5.29.3/File/Find.pm line 375.
t/critic.t ............ Dubious, test returned 2 (wstat 512, 0x200)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant