Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read saveset name from the right place #168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bictorv
Copy link

@bictorv bictorv commented Jun 10, 2024

Support DUMPER format 6, which has saveset name at different offset. Also check dumper tape format and reject too old or invalid format codes.

This lets this program display the right saveset name for more tapes e.g. in http://www.bitsavers.org/bits/DEC/pdp10/magtape/dec_distribs/TOPS-20/.

Support DUMPER format 6, which has saveset name at different offset. Also check dumper tape format and reject too old or invalid format codes.

read_asciz (name, &data[3]);
// Check tape format! Otherwise breaks e.g. on Install tapes (which aren't in dumper format).
if ((data[0] < 4) || (data[0] > 6)) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this work with TENEX' MINI-DUMPER?

read_asciz (name, &data[3]);
// Check tape format! Otherwise breaks e.g. on Install tapes (which aren't in dumper format).
if ((data[0] < 4) || (data[0] > 6)) {
// Formats older than 4 not supported, and 6 was the highest (TOPS-20 v6-7).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formats 1-3 would be supported if I knew how. Format 0 is MINI-DUMPER.

@bictorv
Copy link
Author

bictorv commented Jun 14, 2024

Format 0 has a different header, as far as I can tell. See TOPS-20 v4 DUMPER for some ways of handling it (there it is called TENEX/BBN format). Here, you should probably do the same check as at SETHDR there, to see if it is ASCII directly in the format field (rather than a format code). But I guess there are more differences - does dumper.c handle TENEX dumper files as it is now?

Can you point at some tape file in that format?

@larsbrinkhoff
Copy link
Owner

My main purpose for writing this dumper.c was to create TENEX mini-dumper files. I don't have any tape samples from a real TENEX system. I have been testing the output from my program against MINI-DUMPER running on TENEX, and it seemed to work. You could of course create some tape files with dumper.c but I can't guarantee they are 100% correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants