Skip to content

Commit

Permalink
fix: Don't pace during QNS zerortt test (mozilla#2115)
Browse files Browse the repository at this point in the history
If we pace, we might get the initial server flight before sending
sufficient 0-RTT data to pass the QNS check.

Broken out of mozilla#1998
  • Loading branch information
larseggert authored Sep 16, 2024
1 parent 1841054 commit 75372c2
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions neqo-bin/src/client/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -245,15 +245,26 @@ impl Args {
"handshake" | "transfer" | "retry" | "ecn" => {
self.shared.use_old_http = true;
}
"zerortt" | "resumption" => {
"resumption" => {
if self.urls.len() < 2 {
qerror!("Warning: resumption tests won't work without >1 URL");
qerror!("Warning: resumption test won't work without >1 URL");
exit(127);
}
self.shared.use_old_http = true;
self.resume = true;
}
"zerortt" => {
if self.urls.len() < 2 {
qerror!("Warning: zerortt test won't work without >1 URL");
exit(127);
}
self.shared.use_old_http = true;
self.resume = true;
// PMTUD probes inflate what we sent in 1-RTT, causing QNS to fail the test.
self.shared.quic_parameters.no_pmtud = true;
// If we pace, we might get the initial server flight before sending sufficient
// 0-RTT data to pass the QNS check. So let's burst.
self.shared.quic_parameters.no_pacing = true;
}
"multiconnect" => {
self.shared.use_old_http = true;
Expand Down

0 comments on commit 75372c2

Please sign in to comment.