test: check pkglock is updated correctly #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsgw
requested changes
Oct 29, 2018
| @@ -89,6 +105,47 @@ test('development dependency identification', function (t) { | |||
| t.is(code, 0, 'no error code') | |||
| t.is(stderr, '', 'no error output') | |||
| t.notOk(fs.existsSync(path.join(devDir, 'node_modules')), 'did not install anything') | |||
| t.similar(JSON.parse(fs.readFileSync(path.join(optionalDir, 'package-lock.json'), 'utf8')), { | |||
| dependencies: { | ||
| a: { | ||
| version: 'file:../a-1.0.0.tgz', | ||
| optional: true, |
There was a problem hiding this comment.
And these ones changed accordingly to dev: true.
| optional: true, | ||
| } | ||
| } | ||
| }, 'locks dependencies as optional') |
There was a problem hiding this comment.
And then this should be dev too.
|
@larsgw nice one, thanks for the feedback! Pushed the fixes 👌 |
larsgw
approved these changes
Oct 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@larsgw awesome work on this fix! I've been trying to understand what it's doing and added a few tests to check the lockfile was updated correctly.
Let me know if this makes sense and is helpful!
Also fyi, pushed a fix for the failing spec in the
release-nextbranch: npm#88