STYLE: Fix build warnings on linux

Fixed build warnings reported by this github action:
https://github.com/Slicer/Slicer/actions/runs/11829892124/job/32962501349

Libs/MRML/Core/vtkImageMathematicsAddon.cxx

@@ -152,8 +152,7 @@ void vtkImageMathematicsAddonExecute2(vtkImageMathematicsAddon* self, vtkImageDa
   unsigned long count = 0;
   unsigned long target;
   int op = self->GetOperation();
-  int divideByZeroToC = self->GetDivideByZeroToC();
-  double constantc = self->GetConstantC();
+
   double normalizeScalarRange[2] = { 0.0, 1.0 };
   self->GetRange(normalizeScalarRange);
   double normalizeMagnitude = normalizeScalarRange[1] - normalizeScalarRange[0];
@@ -170,6 +169,18 @@ void vtkImageMathematicsAddonExecute2(vtkImageMathematicsAddon* self, vtkImageDa
   inData->GetContinuousIncrements(outExt, inIncX, inIncY, inIncZ);
   outData->GetContinuousIncrements(outExt, outIncX, outIncY, outIncZ);
 
+  if (op != VTK_MULTIPLYBYSCALEDRANGE)
+  {
+    vtkErrorWithObjectMacro(self, << "Execute: Unknown operation: " << op);
+    return;
+  }
+
+  if (normalizeMagnitude == 0.0)
+  {
+    vtkErrorWithObjectMacro(self, << "Execute: normalizeScalarRange width is zero");
+    return;
+  }
+
   // Loop through output pixels
   for (idxZ = 0; idxZ <= maxZ; idxZ++)
   {
@@ -185,15 +196,7 @@ void vtkImageMathematicsAddonExecute2(vtkImageMathematicsAddon* self, vtkImageDa
       }
       for (idxR = 0; idxR < rowLength; idxR++)
       {
-        // Pixel operation
-        switch (op)
-        {
-        case VTK_MULTIPLYBYSCALEDRANGE:
-          *outPtr = *inPtr * static_cast<float>((*outPtr - normalizeScalarRange[0]) / normalizeMagnitude);
-          break;
-        default:
-          break;
-        }
+        *outPtr = *inPtr * static_cast<float>((*outPtr - normalizeScalarRange[0]) / normalizeMagnitude);
         outPtr++;
         inPtr++;
       }

Libs/MRML/Core/vtkImplicitInvertableBoolean.h

@@ -50,6 +50,7 @@ class VTK_MRML_EXPORT vtkImplicitInvertableBoolean : public vtkImplicitBoolean
   /**
    * Evaluate boolean combinations of implicit function using current operator.
    */
+  using vtkImplicitBoolean::EvaluateFunction;
   double EvaluateFunction(double x[3]) override;
   //@}
 

Libs/MRML/Core/vtkMRMLClipNode.cxx

@@ -556,7 +556,7 @@ int vtkMRMLClipNode::GetClippingNodeState(const char* nodeID)
 int vtkMRMLClipNode::GetNthClippingNodeState(int n)
 {
   NodeReferenceListType references = this->NodeReferences[ClippingNodeReferenceRole];
-  if (references.size() <= n)
+  if (references.size() <= static_cast<size_t>(n))
   {
     return ClipOff;
   }
@@ -596,7 +596,7 @@ void vtkMRMLClipNode::SetClippingNodeState(const char* nodeID, int state)
 void vtkMRMLClipNode::SetNthClippingNodeState(int n, int state)
 {
   NodeReferenceListType references = this->NodeReferences[ClippingNodeReferenceRole];
-  if (references.size() <= n)
+  if (references.size() <= static_cast<size_t>(n))
   {
     return;
   }

Libs/MRML/Core/vtkMRMLNode.cxx

@@ -2068,7 +2068,7 @@ bool vtkMRMLNode::vtkMRMLNodeReference::SetProperty(const std::string& key, cons
   bool modified = false;
   if (propertiesIt != this->Properties.end())
   {
-    if (propertiesIt->second != value);
+    if (propertiesIt->second != value)
     {
       modified = true;
       propertiesIt->second = value;
@@ -2160,7 +2160,7 @@ void vtkMRMLNode::SetNthNodeReferenceProperty(const std::string& referenceRole,
   }
 
   NodeReferenceListType& references = this->NodeReferences[std::string(referenceRole)];
-  if (n < 0 || n >= references.size())
+  if (n < 0 || static_cast<size_t>(n) >= references.size())
   {
     return;
   }

Libs/MRML/Core/vtkMRMLTextStorageNode.cxx

@@ -242,7 +242,7 @@ const char* vtkMRMLTextStorageNode::GetDefaultWriteFileExtension()
   vtkStringArray* fileTypes = this->GetSupportedWriteFileTypes();
   if (fileTypes && fileTypes->GetNumberOfValues() > 0)
   {
-    std::string fileExtension = vtkDataFileFormatHelper::GetFileExtensionFromFormatString(fileTypes->GetValue(0));
+    std::string fileExtension = vtkDataFileFormatHelper::GetFileExtensionFromFormatString(fileTypes->GetValue(0).c_str());
     if (!fileExtension.empty())
     {
       // Remove leading "."

Modules/Loadable/Segmentations/EditorEffects/qSlicerSegmentEditorPaintEffect.cxx

@@ -235,8 +235,8 @@ qSlicerSegmentEditorPaintEffectPrivate::qSlicerSegmentEditorPaintEffectPrivate(q
   , ActiveViewWidget(nullptr)
   , PaintOptionsFrame(nullptr)
   , BrushDiameterFrame(nullptr)
-  , BrushDiameterSliderWidget(nullptr)
   , BrushDiameterSizeFrame(nullptr)
+  , BrushDiameterSliderWidget(nullptr)
   , BrushDiameterIsAbsoluteButton(nullptr)
   , BrushSphereCheckbox(nullptr)
   , EditIn3DViewsCheckbox(nullptr)

Modules/Loadable/Transforms/MRMLDM/vtkMRMLLinearTransformsDisplayableManager.cxx

@@ -275,16 +275,19 @@ void vtkMRMLLinearTransformsDisplayableManager::OnMRMLSceneNodeAdded(vtkMRMLNode
     return;
   }
 
-  vtkMRMLTransformNode* transformNode = nullptr;
-  vtkMRMLTransformDisplayNode* displayNode = nullptr;
-  if (transformNode = vtkMRMLTransformNode::SafeDownCast(node))
+  vtkMRMLTransformNode* transformNode = vtkMRMLTransformNode::SafeDownCast(node);
+  if (transformNode)
   {
     this->Internal->AddObservations(transformNode);
+    return;
   }
-  else if (displayNode = vtkMRMLTransformDisplayNode::SafeDownCast(node))
+
+  vtkMRMLTransformDisplayNode* displayNode = vtkMRMLTransformDisplayNode::SafeDownCast(node);
+  if (displayNode)
   {
     this->Internal->UpdatePipelineFromDisplayNode(vtkMRMLTransformDisplayNode::SafeDownCast(node));
     this->RequestRender();
+    return;
   }
 }
 
@@ -298,19 +301,22 @@ void vtkMRMLLinearTransformsDisplayableManager::OnMRMLSceneNodeRemoved(vtkMRMLNo
     return;
   }
 
-  vtkMRMLTransformNode* transformNode = nullptr;
-  vtkMRMLTransformDisplayNode* displayNode = nullptr;
-
   bool modified = false;
-  if (transformNode = vtkMRMLTransformNode::SafeDownCast(node))
+
+  vtkMRMLTransformNode* transformNode = vtkMRMLTransformNode::SafeDownCast(node);
+  if (transformNode)
   {
     this->Internal->RemoveObservations(transformNode);
     modified = true;
   }
-  else if (displayNode = vtkMRMLTransformDisplayNode::SafeDownCast(node))
+  else
   {
-    this->Internal->UpdatePipelineFromDisplayNode(displayNode);
-    modified = true;
+    vtkMRMLTransformDisplayNode* displayNode = vtkMRMLTransformDisplayNode::SafeDownCast(node);
+    if (displayNode)
+    {
+      this->Internal->UpdatePipelineFromDisplayNode(displayNode);
+      modified = true;
+    }
   }
 
   if (modified)

Modules/Loadable/Transforms/qSlicerTransformsModuleWidget.cxx

@@ -417,7 +417,6 @@ void qSlicerTransformsModuleWidget::updateCenterOfTransformationWidgets()
   {
     vtkNew<vtkGeneralTransform> transform;
     d->MRMLTransformNode->GetTransformToWorld(transform);
-    double coordinates_World[3] = { 0.0, 0.0, 0.0 };
     transform->TransformPoint(centerOfTransformation, centerOfTransformation);
   }
 

Modules/Loadable/Transforms/qSlicerTransformsReader.cxx

@@ -130,7 +130,6 @@ double qSlicerTransformsReader::canLoadFileConfidence(const QString& fileName)co
       using ImageIOType = itk::NiftiImageIO;
       ImageIOType::Pointer niftiIO = ImageIOType::New();
       niftiIO->SetFileName(fileName.toStdString());
-      bool readSuccessful = false;
       try
       {
         niftiIO->ReadImageInformation();