[vscode][7/n] Setup Env Variables: Connect missing API keys error to command #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossdanlm
force-pushed
the
pr1300
branch
2 times, most recently
from
9341297 to
781a7d7
Compare
rossdanlm
requested review from
saqadri,
rholinshead,
suyoglastmileai,
Ankush-lastmile and
jonathanlastmileai
as code owners
rholinshead
approved these changes
Feb 22, 2024
| // logic is defined in https://github.com/lastmile-ai/aiconfig/blob/33fb852854d0bd64b8ddb4e52320112782008b99/python/src/aiconfig/util/config_utils.py#L41 | ||
| if (message.includes("Missing API key")) { | ||
| notificationAction = await notificationFn( | ||
| "Looks like you're missing an API key, please set it in your env variables", |
There was a problem hiding this comment.
One thing I found out recently is that vscode has MarkdownString which can be used in some vscode components. If it works, would be great to use to show documentation link here as well:
const message = new vscode.MarkdownString();
message.appendMarkdown(
"Looks like you're missing an API key. Please set it in your <a href='https://aiconfig.lastmileai.dev/docs/getting-started/#setup-your-api-keys' target='_blank'>.env variables</a>"
);
message.isTrusted = true; // allow links to be clickable -- not sure if needed
There was a problem hiding this comment.
I tried getting this to work but wasn't able to for diagnostics messaging. Seems like it's still an open issue: microsoft/vscode#54272
rossdanlm
added a commit
that referenced
this pull request
Feb 22, 2024
…put (#1291) [vscode][6/n] Setup Env Variables: Add more validation to env path input Added two noteworthy checks that we didn't have before: 1. The filename itself must be ".env" (before it only checked for ending so things like "invalid/filename.env" could be valid) 2. The path must be a subset of the workspace path, to ensure that when we call the `loadenv()` function from Python in AIConfig SDK, it's able to access this `.env` file I also made this into a separate function to keep it cleaner ## Test Plan https://github.com/lastmile-ai/aiconfig/assets/151060367/d77305c4-2cc6-4cb8-a918-b74826ff3714 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/lastmile-ai/aiconfig/pull/1291). * #1300 * __->__ #1291
…command Now it's more intuitive for users to know what needs to be done when they receive this error. I also moved the logic for the command into a utils file so it can be accessed both by activation flow and the error checking flow in the editor ## Test Plan Getting missing API key error https://github.com/lastmile-ai/aiconfig/assets/151060367/cc6c51e5-d205-4afa-a3b4-dc04f68d4946 Walkthrough commands https://github.com/lastmile-ai/aiconfig/assets/151060367/bda40b3c-d260-40a2-82da-563d363152b3
|
Updated content a bit 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[vscode][7/n] Setup Env Variables: Connect missing API keys error to command
Now it's more intuitive for users to know what needs to be done when they receive this error. I also moved the logic for the command into a utils file so it can be accessed both by activation flow and the error checking flow in the editor
Test Plan
Getting missing API key error
559b2a29-b906-46c8-815b-2f90b0ce9299.mp4
Walkthrough commands
c0dd6d72-4fd3-4c51-ac84-9ae76a3e9cd7.mp4
Stack created with Sapling. Best reviewed with ReviewStack.