-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add method to add multiple outputs to a prompt in AIConfig #689
Merged
rossdanlm
merged 5 commits into
lastmile-ai:main
from
sp6370:option_to_add_a_list_of_outputs_to_config
Jan 3, 2024
Merged
Feat: Add method to add multiple outputs to a prompt in AIConfig #689
rossdanlm
merged 5 commits into
lastmile-ai:main
from
sp6370:option_to_add_a_list_of_outputs_to_config
Jan 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossdanlm
reviewed
Jan 2, 2024
rossdanlm
reviewed
Jan 2, 2024
rossdanlm
reviewed
Jan 2, 2024
rossdanlm
reviewed
Jan 2, 2024
rossdanlm
reviewed
Jan 2, 2024
rossdanlm
approved these changes
Jan 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Great work, thanks for adding this feature and doing such great and thorough test plans!!!
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request adds ability to add multiple outputs to prompt for Python SDK.
Changes Made:
Added the add_outputs method to add multiple outputs to a prompt.
Related Issues:
Closes #153
Test Plan:
test_add_outputs_existing_prompt_no_overwrite
.add_outputs
support prompt output overwritingtest_add_outputs_existing_prompt_overwrite
.add_outputs
is invoked with empty list or no outputstest_add_empty_outputs_to_prompt
.