Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Add method to add multiple outputs to a prompt in AIConfig #689

Merged
merged 5 commits into from
Jan 3, 2024
Merged

Feat: Add method to add multiple outputs to a prompt in AIConfig #689

merged 5 commits into from
Jan 3, 2024

Conversation

sp6370
Copy link
Contributor

@sp6370 sp6370 commented Jan 2, 2024 •
edited by rossdanlm
Loading

Summary:
This pull request adds ability to add multiple outputs to prompt for Python SDK.

Changes Made:
Added the add_outputs method to add multiple outputs to a prompt.

Related Issues:
Closes #153

Test Plan:

  • Test to check that multiple outputs can be added to prompt test_add_outputs_existing_prompt_no_overwrite.
  • Test to check that add_outputs support prompt output overwriting test_add_outputs_existing_prompt_overwrite.
  • Test to check that exception is raised if add_outputs is invoked with empty list or no outputs test_add_empty_outputs_to_prompt.

rossdanlm
rossdanlm approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@rossdanlm rossdanlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Great work, thanks for adding this feature and doing such great and thorough test plans!!!

@sp6370 sp6370 requested a review from rossdanlm January 2, 2024 19:25
@rossdanlm
Copy link
Contributor

Nice!

@rossdanlm rossdanlm merged commit e47ce1f into lastmile-ai:main Jan 3, 2024
1 check passed
@rossdanlm rossdanlm mentioned this pull request Jan 3, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saqadri saqadri Awaiting requested review from saqadri saqadri is a code owner

@rholinshead rholinshead Awaiting requested review from rholinshead rholinshead is a code owner

@suyoglastmileai suyoglastmileai Awaiting requested review from suyoglastmileai

@Ankush-lastmile Ankush-lastmile Awaiting requested review from Ankush-lastmile Ankush-lastmile is a code owner

@jonathanlastmileai jonathanlastmileai Awaiting requested review from jonathanlastmileai jonathanlastmileai is a code owner

@rossdanlm rossdanlm Awaiting requested review from rossdanlm rossdanlm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

option to add a list of outputs to config
2 participants
@sp6370 @rossdanlm