Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add java.utils.Arrays#deepToString EEA #157

Merged
merged 3 commits into from
Aug 17, 2022
Merged

add java.utils.Arrays#deepToString EEA #157

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d12711d
add java.utils.Arrays#deepToString EEA
sebthom Aug 14, 2022
2f29271
Merge branch 'main' into patch-4
J-N-K Aug 16, 2022
9db9b91
Merge branch 'main' into patch-4
J-N-K Aug 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libraries/java/java/util/Arrays.eea
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@ class java/util/Arrays
asList
<T:Ljava/lang/Object;>([TT;)Ljava/util/List<TT;>;
<T:Ljava/lang/Object;>([TT;)L1java/util/List<TT;>;
deepToString
([Ljava/lang/Object;)Ljava/lang/String;
([Ljava/lang/Object;)L1java/lang/String;
Comment on lines +5 to +7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is again an issue similar to #116 and #141. deepToString can return null https://docs.oracle.com/javase/7/docs/api/java/util/Arrays.html#deepToString(java.lang.Object[]) if the input value is null.

Please express your support to https://bugs.eclipse.org/bugs/show_bug.cgi?id=575822 to get a solution.

Copy link
Member Author

@sebthom sebthom Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc says: This method returns "null" if the specified array is null. So a literal string "null" is returned, not a null value.

Anyways I voted for the issue you linked, I also want something like this.

stream
([D)Ljava/util/stream/DoubleStream;
([D)L1java/util/stream/DoubleStream;
Expand Down